Fix BazelTestRunner compatibility with jre8 #18307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes usages of Set.of() that were introduced in javase9
github-actions
bot
added
awaiting-review
meteorcloudy
approved these changes
May 4, 2023
|
We probably need another java_tools release for this, right? /cc @keertk |
|
@bazel-io fork 6.2.0 |
Yes. Also, if we wish to keep supporting jre8, surely we should keep it in our CI as well? |
|
@hvadehra You can use shell_commands to install jre8 in case you want to set up some minimal tests for this. |
hvadehra
added
awaiting-PR-merge
Pavank1992
removed
the
awaiting-PR-merge
|
@hvadehra can you help with this cherry-pick please? |
|
@keertk I don't think the intention is to cherry pick this change. We want to release java_tools with it, and then cherry pick that. |
|
Ok, got it |
copybara-service bot
pushed a commit
that referenced
this pull request
May 5, 2023
#18307 (comment) bazelbuild/java_tools#71 Closes #18314. PiperOrigin-RevId: 529665382 Change-Id: Iba616a0b705a20dcb5e28d06f431b0a79801d769
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Removes usages of Set.of() that were introduced in javase9 Fixes bazelbuild#18300 Closes bazelbuild#18307. PiperOrigin-RevId: 529369593 Change-Id: Id45afbb1bdee46910f4a9b632f479773c561c0a3
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
bazelbuild#18307 (comment) bazelbuild/java_tools#71 Closes bazelbuild#18314. PiperOrigin-RevId: 529665382 Change-Id: Iba616a0b705a20dcb5e28d06f431b0a79801d769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usages of Set.of() that were introduced in javase9
Fixes #18300